fix(search): fixing pages not loading after search #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When search results lead to the `0.19` version, the page is no correctly loaded. What happens is that the search result shows "page not found" and only after refresh, the page is loaded. Using the `externalUrlRegex to load all the searches related to the `0.19` version in a separate window using `window.location.href` results in the search on `0.19` to load correctly. The drawback of this is that search results for `0.19` load a bit slower because they need to render in a separate window.
✅ Deploy Preview for vcluster-docs-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
URL style vs path style is recommended by docusaurus to avoid broken links
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content Description
When search results lead to the
0.19version, the page is no correctly loaded. What happens is that the search result shows "page not found" and only after refresh, the page is loaded.Using the
externalUrlRegexto load all the searches related to the0.19version in a separate window, usingwindow.location.hrefresults in the search on0.19to load correctly.The drawback of this is that search results for
0.19load a bit slower because they need to render in a separate window.Test the PR
To test the change go to the preview link and insert serach for "synced resources", the top search should take you to the
0.19docs opening in new tab/window (depending on your browser configuraiton).Searches for the current version should render normally on the same page.
Preview Link
What are virtual clusters?
Internal Reference
Closes DOC-380